Repository navigation
fix(android): clean up pending camera temp files on cancel/stop - #970
Open
GitToTheHub wants to merge 1 commit into
Open
GitToTheHub wants to merge 1 commit into
GitToTheHub wants to merge 1 commit into
Conversation
- delete pending image and cropped temp files when camera flow is stopped - run cleanup when image selection/capture is canceled - reset pending URI and file path state after best-effort cleanup Generated-By: GPT-5.3-Codex
5 tasks
erisu
reviewed
Sep 16, 2026
| * Best-effort cleanup for temporary files when capture/selection is cancelled or stopped. | ||
| */ | ||
| private void cleanupPendingResultFiles() { | ||
| deleteIfExists(this.imageUri); |
Member
There was a problem hiding this comment.
I think the imageUri contains a content:// URI, and the deleteIfExists method which uses new File(filePath).delete() would not work as it expects a filesystem path.
I believe we would need to use the ContentResolver to delete the file by passing in the imageUri.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Follow up of PR #873.
@erisu noticed after PR #873 was merged, if there should be any cleanup procedures after
stopwas called. For example whentakePictureis executedthis.imageUriis set and gets not cleared. After checking this, it turned out, that this is the case, but this was also true, when an Activity was canceled by the user. This fixes both cases.Description
Generated-By: GPT-5.3-Codex
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))